fix: use server time for calling (WPB-10979) #3017

ohassine · 2024-09-17T10:43:39Z

WPB-10979 [Android] No call notifications incoming on graphene device on bund-next-col1 backend

PR Submission Checklist for internal contributors

The PR Title
- conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- contains a reference JIRA issue number like SQPIT-764
- answers the question: If merged, this PR will: ... ³
The PR Description
- is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

No call notifications incoming if device time is not correct

Causes (Optional)

If device time is different from the server, AVS will return shouldRing flag as false causing the app to not show any incoming call notification

Solutions

On event processing we calculate time offset that will be used later to get server time

Edit:
I changed the logic so now we get serverTime by fetching /notifications api with only querySize value.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

GitHub link to other pull request

Testing

Test Coverage (Optional)

I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

PR Post Submission Checklist for internal contributors (Optional)

Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References

https://sparkbox.com/foundry/semantic_commit_messages
https://github.com/wireapp/.github#usage
E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

github-actions · 2024-09-17T10:52:49Z

Test Results

3 219 tests +3 3 113 ✅ +3 4m 41s ⏱️ +50s
552 suites ±0 106 💤 ±0
552 files ±0 0 ❌ ±0

Results for commit 261f579. ± Comparison against base commit 75b92ab.

♻️ This comment has been updated with latest results.

codecov-commenter · 2024-09-17T11:08:54Z

Codecov Report

Attention: Patch coverage is 52.17391% with 11 lines in your changes missing coverage. Please review.

Project coverage is 52.43%. Comparing base (75b92ab) to head (261f579).
Report is 1 commits behind head on develop.

Files with missing lines	Patch %	Lines
...in/com/wire/kalium/logic/util/ServerTimeHandler.kt	0.00%	7 Missing ⚠️
.../network/api/v0/authenticated/NotificationApiV0.kt	0.00%	2 Missing and 1 partial ⚠️
.../network/api/v3/authenticated/NotificationApiV3.kt	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3017      +/-   ##
===========================================
- Coverage    52.52%   52.43%   -0.10%     
===========================================
  Files         1305     1309       +4     
  Lines        50225    50337     +112     
  Branches      4680     4671       -9     
===========================================
+ Hits         26383    26392       +9     
- Misses       21956    22057     +101     
- Partials      1886     1888       +2

Files with missing lines	Coverage Δ
...n/kotlin/com/wire/kalium/logic/data/event/Event.kt	`78.17% <100.00%> (ø)`
...om/wire/kalium/logic/data/event/EventRepository.kt	`56.45% <100.00%> (+3.82%)`	⬆️
...ire/kalium/logic/sync/incremental/EventGatherer.kt	`80.00% <100.00%> (+1.51%)`	⬆️
...base/authenticated/notification/NotificationApi.kt	`20.00% <ø> (ø)`
.../network/api/v3/authenticated/NotificationApiV3.kt	`83.33% <0.00%> (-8.34%)`	⬇️
.../network/api/v0/authenticated/NotificationApiV0.kt	`49.23% <0.00%> (-3.16%)`	⬇️
...in/com/wire/kalium/logic/util/ServerTimeHandler.kt	`0.00% <0.00%> (ø)`

... and 21 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75b92ab...261f579. Read the comment docs.

datadog-wireapp · 2024-09-17T11:10:07Z

Datadog Report

Branch report: user-server-time-for-calling
Commit report: 5e441d4
Test service: kalium-jvm

✅ 0 Failed, 3113 Passed, 106 Skipped, 20.43s Total Time

logic/src/commonMain/kotlin/com/wire/kalium/logic/util/ServerTimeHandler.kt

…to user-server-time-for-calling

github-actions · 2024-09-26T12:44:25Z

Bencher Report

Branch	user-server-time-for-calling
Testbed	ubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!
Latency
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results

Benchmark	Latency	nanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles	📈 view plot ⚠️ NO THRESHOLD	688,070.34
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory	📈 view plot ⚠️ NO THRESHOLD	340,774,610.96
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark	📈 view plot ⚠️ NO THRESHOLD	926,401,902.19
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark	📈 view plot ⚠️ NO THRESHOLD	21,503,906.92

🐰 View full continuous benchmarking report in Bencher

MohamadJaara · 2024-10-01T13:17:52Z

@ohassine can you please fix the conflicts

…or-calling # Conflicts: # logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/UserSessionScope.kt

sonarcloud · 2024-10-08T13:12:04Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

* fix: use server time for calling * chore: address comments * fix: get serverTime after websocket is connected * chore: cleanup * chore: broken unit test

fix: use server time for calling

57fcadf

echoes-hq bot added the echoes: bugs Technical or functional defects in the product label Sep 17, 2024

ohassine requested review from a team, typfel, yamilmedina, alexandreferris, MohamadJaara and Garzas and removed request for a team September 17, 2024 10:43

github-actions bot assigned ohassine Sep 17, 2024

github-actions bot added 🚨 Potential breaking changes type: bug / fix 🐞 👕 size: M labels Sep 17, 2024

MohamadJaara reviewed Sep 17, 2024

View reviewed changes

logic/src/commonMain/kotlin/com/wire/kalium/logic/util/ServerTimeHandler.kt Outdated Show resolved Hide resolved

yamilmedina reviewed Sep 17, 2024

View reviewed changes

logic/src/commonMain/kotlin/com/wire/kalium/logic/util/ServerTimeHandler.kt Show resolved Hide resolved

ohassine added 2 commits September 24, 2024 10:06

chore: address comments

432929d

Merge branch 'develop' into user-server-time-for-calling

6923a8c

ohassine requested review from yamilmedina and MohamadJaara September 24, 2024 08:15

ohassine added 4 commits September 26, 2024 14:24

fix: get serverTime after websocket is connected

49b64f8

Merge branch 'develop' into user-server-time-for-calling

d105368

chore: cleanup

1e99622

Merge remote-tracking branch 'origin/user-server-time-for-calling' in…

212266c

…to user-server-time-for-calling

ohassine requested a review from vitorhugods September 26, 2024 12:34

yamilmedina approved these changes Sep 27, 2024

View reviewed changes

MohamadJaara approved these changes Oct 1, 2024

View reviewed changes

Merge remote-tracking branch 'origin/develop' into user-server-time-f…

d906af5

…or-calling # Conflicts: # logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/UserSessionScope.kt

ohassine enabled auto-merge October 8, 2024 09:50

chore: broken unit test

261f579

ohassine added this pull request to the merge queue Oct 8, 2024

Merged via the queue into develop with commit fc3f3e3 Oct 8, 2024
22 checks passed

ohassine deleted the user-server-time-for-calling branch October 8, 2024 14:01

MohamadJaara pushed a commit that referenced this pull request Oct 18, 2024

fix: use server time for calling (WPB-10979) (#3017)

4357e06

* fix: use server time for calling * chore: address comments * fix: get serverTime after websocket is connected * chore: cleanup * chore: broken unit test

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: use server time for calling (WPB-10979) #3017

fix: use server time for calling (WPB-10979) #3017

ohassine commented Sep 17, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Sep 17, 2024 •

edited

Loading

codecov-commenter commented Sep 17, 2024 •

edited

Loading

datadog-wireapp bot commented Sep 17, 2024 •

edited

Loading

github-actions bot commented Sep 26, 2024 •

edited

Loading

MohamadJaara commented Oct 1, 2024

sonarcloud bot commented Oct 8, 2024

fix: use server time for calling (WPB-10979) #3017

fix: use server time for calling (WPB-10979) #3017

Conversation

ohassine commented Sep 17, 2024 • edited by github-actions bot Loading

PR Submission Checklist for internal contributors

What's new in this PR?

Issues

Causes (Optional)

Solutions

Dependencies (Optional)

Testing

Test Coverage (Optional)

How to Test

Notes (Optional)

Attachments (Optional)

PR Post Submission Checklist for internal contributors (Optional)

PR Post Merge Checklist for internal contributors

References

github-actions bot commented Sep 17, 2024 • edited Loading

Test Results

codecov-commenter commented Sep 17, 2024 • edited Loading

Codecov Report

datadog-wireapp bot commented Sep 17, 2024 • edited Loading

Datadog Report

github-actions bot commented Sep 26, 2024 • edited Loading

Bencher Report

MohamadJaara commented Oct 1, 2024

sonarcloud bot commented Oct 8, 2024

Quality Gate passed

ohassine commented Sep 17, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Sep 17, 2024 •

edited

Loading

codecov-commenter commented Sep 17, 2024 •

edited

Loading

datadog-wireapp bot commented Sep 17, 2024 •

edited

Loading

github-actions bot commented Sep 26, 2024 •

edited

Loading